Forum Moderators: open

Message Too Old, No Replies

Else ... if issue

not checking the last one

         

le_gber

6:11 pm on Dec 10, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



Hi all,

I have a problem and don't understand why. The else if structure works up until the last check where it doesn't. If I put the last check above the previous else...if everything works fine.

Can't figure out what is wrong :(

Here is my code:

function checkStepOne(){
doc = document.sellerReg;
var name = doc.sName;
var address = doc.sAddress;
var phone = doc.sTel;
var email = doc.sEmail;
var board = doc.forSaleBoard;
var price = doc.apq_packTwoPrice.value;
var payment = doc.methodPay;
if (name.value == ""){
window.alert("Form not completed properly\n\nPlease enter the seller's name");
name.focus();
}
else if (address.value == ""){
window.alert("Form not completed properly\n\nPlease enter the seller's address");
address.focus();
}
else if (phone.value == ""){
window.alert("Form not completed properly\n\nPlease enter the seller's phone number");
phone.focus();
}
else if (email.value == ""){
window.alert("Form not completed properly\n\nPlease enter the seller's email address");
email.focus();
}
else if (price == "none"){
if ((board[0].checked == false)&&(board[1].checked == false)){
window.alert("Form not completed properly\n\nPlease select if you require a \'For Sale\' board");
}
}
else if ((payment[0].checked == false)&&(payment[1].checked == false)){
window.alert("Form not completed properly\n\nPlease select your preferred method of payment");
}
}//end function

Thanks for your help

Leo

DrDoc

7:43 pm on Dec 10, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



In your else if, you forgot "value"

...
else if (price.value == "none"){
...

;)

le_gber

7:59 pm on Dec 10, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



DrDoc,

it's in the variable declaration:
var price = doc.apq_packTwoPrice.value;

The check for the board is working, it's the check for the payment method that isn't.

Leo

DrDoc

8:16 pm on Dec 10, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



True... Then do this:

else if (price == "none" && board[0].checked == false && board[1].checked == false){
window.alert("Form not completed properly\n\nPlease select if you require a \'For Sale\' board");
}
else if ((payment[0].checked == false)&&(payment[1].checked == false)){
window.alert("Form not completed properly\n\nPlease select your preferred method of payment");
}

...otherwise it will never get down to the last

else if
if price is "none"

le_gber

8:37 pm on Dec 10, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



yoohoo,

The beers are on me whenever we meet :)

Leo