Welcome to WebmasterWorld Guest from 23.22.250.113

Forum Moderators: open

Message Too Old, No Replies

inquiry about javascript code

     

mike2010

11:53 pm on May 15, 2012 (gmt 0)

10+ Year Member



this dude is helping me trouble shoot this javascript code in order to help get a 'mouseover' sound effect to work on all 3 major browsers.

All he basically added was this code to the .js file , to get it to work... along with commenting out a couple lines of the original code.

since i'm not a js expert, was just wondering if any of this could be a security issue ? I've only asked for help from the guy a couple times.


function getElementsByTagNames(list,obj) {
if (!obj) var obj = document;
var tagNames = list.split(',');
var resultArray = new Array();
for (var i=0;i<tagNames.length;i++) {
var tags = obj.getElementsByTagName(tagNames[i]);
for (var j=0;j<tags.length;j++) {
resultArray.push(tags[j]);
}
}
var testNode = resultArray[0];
if (!testNode) return [];
if (testNode.sourceIndex) {
resultArray.sort(function (a,b) {
return a.sourceIndex - b.sourceIndex;
});
}
else if (testNode.compareDocumentPosition) {
resultArray.sort(function (a,b) {
return 3 - (a.compareDocumentPosition(b) & 6);
});
}
return resultArray;
}





thanks much

MB

mike2010

12:55 am on May 16, 2012 (gmt 0)

10+ Year Member



He wanted me to add Jquery to <head> as well...


<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script>

Fotiman

1:56 pm on May 16, 2012 (gmt 0)

WebmasterWorld Senior Member fotiman is a WebmasterWorld Top Contributor of All Time 5+ Year Member Top Contributors Of The Month



That bit of script is 6 years old and you can read about what it does here:
[quirksmode.org...]

To answer your question, no, it is not a security issue. And that bit of script uses no jQuery, so there must be something elsewhere that's using jQuery.

Lastly, it's best to include all of your scripts at the end of your document just before the closing </body> tag rather than in the <head>.

Hope that helps.
 

Featured Threads

Hot Threads This Week

Hot Threads This Month