I'm not sure what window.focus is referring to - generally window is the parent window (?) If this is causing a "pop under" I'd just remove that line. Also the concept of focus in that thread is a bit different - it refers to what happens when the user clicks back in the main window.
Second, one of the important points from that thread is the concept of the window ID (windowname, in your implementation.)
The windowname should be unique - so let's say you have two links and use "Chicks" in both of them:
<a href="link1html" onClick="return popup(this, 'Chicks')">
<a href="link2.html" onClick="return popup(this, 'Chicks')">
Visualize this:
1. User clicks link, opens popup.
2. User clicks back in main window, which puts the popup behind the main window.
3. User clicks link #2, which loads the new content into the window named "Chicks" which is
currently behind the main window. User does not know this and assumes your site is broken.
If it's too much trouble to re-code these links, leave them as is and just don't use the second parameter, or use it for something else. What you need to do is generate a new window name every time this function is called - a relatively easy way to do that is use the millisecond time of day.
Revised,
<script="text/javascript">
function popup(mylink, windowname) {
var href;
var day = new Date(); // date object
var id = day.getTime(); // millisecond value
href= (typeof(mylink) == 'string')?mylink:mylink.href;
window.open(href, id, 'width=400,height=200,scrollbars');
// "yes" is not needed
return false;
}
</script>
If you can manage to mod all the links,
<a href="your-url" onClick="return popup(this)">
<img SRC="your-image" border=0></a>
all you need is mylink and can remove windowname.
<script="text/javascript">
function popup(mylink) {
var href;
var day = new Date(); // date object
var id = day.getTime(); // millisecond value
href= (typeof(mylink) == 'string')?mylink:mylink.href;
window.open(href, id, 'width=400,height=200,scrollbars');
// "yes" is not needed
return false;
}
</script>
A little BG on what's going on here:
href= (typeof(mylink) == 'string')?mylink:mylink.href;
This is a ternary operator, also known as short circuit evaluation, and is identical to an if/else (but is more compact and looks more cool. :-) ) the if/else allows you to passa valid string or a reference to an object -in this case, when you do this
onClick="return popup(this)"
You are passing a reference to the current anchor object, so it will use that object's href attribute. You could also do this
onClick="return popup(this.href)"
Which will the pass the string that is in the href, "your-url". You could also do this,
onClick="return popup('some-other-url')"
Which would then use "some-other-url" instead of the href - don't know why you'd want to do that, but you could. :-)
