Forum Moderators: open

Message Too Old, No Replies

javascript optimization

help

         

rokec

6:43 pm on Jan 18, 2007 (gmt 0)

10+ Year Member



Can someone optimize or just suggest how to optimize this script?

var time = 3000;
var numofitems = 7;
function menu(allitems,thisitem,startstate){
callname= "gl"+thisitem;
divname="subglobal"+thisitem;
this.numberofmenuitems = 7;
this.caller = document.getElementById(callname);
this.thediv = document.getElementById(divname);
this.thediv.style.visibility = startstate;}
function ehandler(event,theobj){
for (var i=1; i<= theobj.numberofmenuitems; i++){
var shutdiv =eval( "menuitem"+i+".thediv");
shutdiv.style.visibility="hidden";}
theobj.thediv.style.visibility="visible";}
function closesubnav(event){
if ((event.clientY <48)¦¦(event.clientY > 107)){
for (var i=1; i<= numofitems; i++){
var shutdiv =eval('menuitem'+i+'.thediv');
shutdiv.style.visibility='hidden';}}}

Thanks in advance.

Fotiman

11:24 pm on Jan 18, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member Top Contributors Of The Month



My suggestion would be to store the menuitems in a variable instead of having to "eval" them every time in your ehandler and closesubnav methods.