Problem with Apostrophes '

[aax123]

What is wrong with the code below? I am trying to replace an apostrophe ' with double apostrophes in the value and it takes off the ' apostrophe but doesn't add ''
i.e. "Won't Last" now reads "Wont Last"
--------------------------

if (eval("document.forms[0].elements['linerTextAndDescriptionAdj_" + vid + "'].value")!= "") {
eval("divPreview" + vid + ".innerText = '" + eval("document.forms[0].elements['linerTextAndDescriptionAdj_" + vid + "'].value.replace(/'/g,'')") + "'");
}

[Bernard Marx]

Do you have to do it like that?

Is "divPreview"+vid an element id, or a global variable holding a reference to an element?

[aax123]

It is a variable.

var divPreview = eval("divPreview" + vid);
divPreview.innerHTML = newText.replace(/\n/g,"<br>");

[Bernard Marx]

<edit reason="missing quotes">

var divPreview = window["divPreview"+vid];

[aax123]

Adding this didn't help.

var divPreview = window["divPreview"+vid];

[httpwebwitch]

you are replacing ' with ''
'' is an empty string.
you probably want '\'\''
or "''"

try it anyways, see if it works

[Bernard Marx]

Javascript is an advanced, object-oriented programming language. You don't need to use primitive approaches such as building up commands by concatenating strings. Doing so is just like riding a bicycle and pushing the pedals with your hands.