Adding OnClick property to dynamicly genertated Images

[orhor]

Hi,

this is my question, I wrote a script that generates new IMGs in my page. I need to add a onClick property to these newly generated images. I would like to have some javascript solution, that would work the same way like if the images would be written in HTML they had these tags: <img onClick='javascript: myFunction("thisImageId");'>

this is a part of my code:

function addNewImg(newImageId){
newImg = document.createElement('img');
newImg.id = "image"+newImageId;
newImg = document.getElementById("divimage1").appendChild(newImg);
document.getElementById("image"+newImageId).onclick=ppEdit("image"+newImageId,"image"); // this is the line that doesnt work for me
}
sorry for my english, any help will be greatly appreciated

[RonPK]

Just a wild guess, but it may work:

newImg.onclick = ppEdit("image"+newImageId);

I'm not so confident about passing parameters to event handlers, but you'll soon notice if that causes problems ;)

[orhor]

thanks for answering, but unfortunatly this doesn't work...

[orhor]

there are some strange things I cant understand:

when I use this:

function klik(){
alert("ppp");
}

function addNewImg(newImageId){
newImg = document.createElement('img');
newImg.id = "image"+newImageId;
newImg = document.getElementById("divimage1").appendChild(newImg);
newImg.onclick=klik
}

it works. The new image is created and after clicking on it "ppp" is alerted.

but when I use this:

function klik(ff){
alert(ff);
}

function addNewImg(newImageId){
newImg = document.createElement('img');
newImg.id = "image"+newImageId;
newImg = document.getElementById("divimage1").appendChild(newImg);
newImg.onclick=klik("ppp");
}

"ppp" is alerted in the moment of executing the statement newImg.onclick=klik("ppp"); and when clicking on the generated image nothing happens, even Javascript Console of Firefox stays blind.

I googled a bit and found that the first example shoul be used, but I need to use some argument to be able to edit the generated image later. And what if there will be 10 generated images?

[orhor]

so I got the solution from jscheuer1 at codingforum.com:

function addNewImg(newImageId){
newImg = document.createElement('img');
newImg.id = "image"+newImageId;
newImg = document.getElementById("divimage1").appendChild(newImg);
var onC='ppEdit("image'+newImageId+'","image")';
document.getElementById("image"+newImageId).onclick=new Function(onC);
}

it works

[orhor]

alternative solution:

document.getElementById("image"+newImageId).onclick=function(){
ppEdit(this.id, "image");
}

[RonPK]

Glad you worked it out. I told you that passing parameters to event handlers can get messy ;)

[webaster]

maybe an object detection be great to add too
why?
So browsers that understand document.getElementById,
document.createElement execute the code.

function addNewImg(newImageId){
//object detection check
if (!document.getElementById &&!document.createElement){return;}
newImg = document.createElement('img');
newImg.id = "image"+newImageId;
newImg = document.getElementById("divimage1").appendChild(newImg);
var onC='ppEdit("image'+newImageId+'","image")';
document.getElementById("image"+newImageId).onclick=new Function(onC);
}

alternative solution:
if (!document.getElementById) {return;}
document.getElementById("image"+newImageId).onclick=function(){
ppEdit(this.id, "image");
}

[webaster]

forgot a whitespace there:

if (!document.getElementById &&!document.createElement){return;}

[webaster]

forgot a whitespace there:

if (!document.getElementById &&!document.createElement){return;}

[webaster]

sorry for that it is the editor I guess

[orhor]

thanks to everyone of you