Welcome to WebmasterWorld Guest from 54.205.74.11

Forum Moderators: open

is this a js frame buster?

   
5:56 pm on Jan 9, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



I'm using this in all my pages and am having some problems seeing the page when it is redirected from an se and when trying to see the page from wusage report referrers.

<script TYPE="text/javascript">
if(top.location!= document.location)
top.location = document.location;
</script>

have I screwed up the code or will I see these problems because I'm using this?

Thanks

<added> I'm using it in the head section </added>

7:02 pm on Jan 9, 2003 (gmt 0)

WebmasterWorld Senior Member jdmorgan is a WebmasterWorld Top Contributor of All Time 10+ Year Member



nancyb,

I had a similar problem, especially when framed by Lycos's "Fast Forward" feature. The frame-escape would often leave "broken" html fragments on the page.

I fixed it by moving the frame buster to the bottom of the page. Since the page is already (usually) cached, it the reload isn't usually disuptive.

Here's the code I was using:


<script language="JavaScript1.1" type="text/JavaScript"> <!--
if (parent.frames.length > 0) top.location.replace(document.location); // Escape from frame, but retain one-click "Back". -->
</script>
</body>
</html>

I'd love to hear some better suggestions - I got it working and forgot about it, but it's rather inelegant.

Jim

7:38 pm on Jan 9, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



Thanks, Jim. In-elegant or not, I'll change mine, too, especially since I wouldn't have a clue that it ever was inelegant :)
7:58 pm on Jan 9, 2003 (gmt 0)

WebmasterWorld Senior Member jdmorgan is a WebmasterWorld Top Contributor of All Time 10+ Year Member



nancyb,

What I meant was that moving my code to the bottom of the page where it will force a reload (but usually from the browser cache) was inelegant - I certainly meant no disrespect to your code. Moving the frame-buster fixed the problem I was seeing, but forced the entire page to be reloaded - so I considered it a "band-aid" fix.

Earnestly awaiting more opinions...

Jim

8:05 pm on Jan 9, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



Jim,

Oh, goodness, I was not clear. I did not think you were refering to my code! I was "trying" to be humerous about your comment of inelegant. I know nothing about js. But, thanks for the clarification on how it would cause a reload.

 

Featured Threads

My Threads

Hot Threads This Week

Hot Threads This Month