Showing elements

Having issues using visibility

[Numberman]

I'm having trouble displaying a div element.

Exerp from my func.js:

// Functions
function hide(id)
{
element = document.GetElementById(id);
element_id.style.visibility = "hidden";
}
function show(id)
{
element = document.getElementById(id);
element_id.style.visibility = "show";
}

The DIV:

<div id="divgallerymenu" style="position:absolute; left:161px; top:276px; width:159px; height:190px; z-index:1; background-color: #FF0000; layer-background-color: #FF0000; border: 1px none #000000; visibility:hidden">
 <p>Flash Gallery</p>
 <p>Animated GIF</p>
 <p>Picture</p>
</div>

The link:

<a href="javascript://" onClick="show('divgallerymenu')">Galleries</a>

I'd appreciate some help. The DIV refuses to show.

[DrDoc]

element_id.style.visibility = "show";

That should be:

element_id.style.visibility = "visible";

[Numberman]

I feel very stupid for making that mistake, but the corrected version still doesn't work. I've tried it in both FireFox and Internet Explorer.

[Bernard Marx]

element = document.GetElementById(id);
element_id.style.visibility = "hidden";

:)

PS write:

var element = document.getElementById(id);

to make it a local variable. Not an 'error', but better.

AND

This:

<a href="javascript://" onClick="show('divgallerymenu')">Galleries</a>

might be better as:

<a href="#" onClick="show('divgallerymenu');return false">Galleries</a>

[Rambo Tribble]

Just so you aren't confused, show is the old Netscape 4 layers terminology. Also note that after you declare your element as var element, you must use it as element, not element_id.

[Numberman]

Your help was greatly appreciated.