Trying to use formmail as way for people to sign up for my newsletter

Almost got it - so close - php script

[anon123]

Hi, my formmail script is working great, except for 1 little problem which should probably be an easy fix, but I can't figure it out.

I need to have the email being sent from the email that people are inputting on the form.

To sign up for my newsletter, people need to email [e-mail] with "subscribe" in the subject, and it does that - BUT- for some reason it ends up sending it from [e-mail]. So it doesn't subcribe the email people are inputting into the form, but rather the [e-mail] email over and over.

Right now, it sends the email to the correct address, with the correct subject, but it's not sending it from the email being input into the form.

Does anyone know how to correct this?

I'm using a free formmail php script.

Here's the code:

<FORM ACTION="http://www.mysite.com/formmail.php" METHOD=POST>
<input type=hidden name="recipient" value="[e-mail]">
<input type=hidden name="subject" value="subscribe"> 
<input type=text name="email">
<input type=hidden name="redirect" value="http://www.mysite.com/newsletter/success">
<input type=hidden name="require" value="email">

<br><br>

<FORM METHOD="LINK" ACTION="http://www.mysite.com/formmail.php">
<INPUT TYPE="submit" VALUE="Submit">
</FORM>

[rocknbil]

That's not the code doing this, it's in this:

formmail.php

Or . . . maybe you're missing some field or have named the from email field incorrectly (don't know, check the author's documentation.)

Remember, of course,that "email" and "Email" are not the same input variable.

At any rate the "from" is in the mail headers.

$headers = "From: $who_you_want_it_from\r\n";
$headers .= 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";

mail($who_you_want_it_to, $subject, $msg, $headers);

So whatever variable is being used to create the headers is the "from" you're looking for.

[anon123]

Hi rocknbil, thanks for the reply.

I think I found the part of the formmail.php your talking about, but still not quite sure what to do.

Here is the code:

$mail_header = 'Return-Path: ' . eregi_replace($email_replace_array,'',$return_path) . $mail_newline;
if (FROM != null)
$mail_header .= 'From: ' . FROM . $mail_newline;
$mail_header .= 'Reply-to: ';

So, from the HTML code in my first post, should I be changing the "From:" part in the code above to "From:'email'" to get it to match up?

Sorry for the newbie question and thanks for your help!

[rocknbil]

No . . nothing in the form will affect this, that I can tell. It's happening here:

if (FROM != null)
$mail_header .= 'From: ' . FROM . $mail_newline;

Note the unquoted word FROM. Normally this is a literal string, but the way it's presented in the code, I am guessing it is a program constant. Constants are a little different than variables in that they don't have the ability to change as the program runs, but they are a little bit like a variable in that they still hold a value.

What you are probably looking for is a line like this:

define('FROM', '[e-mail]');

it **MAY** be part of an include. If you have a line like this somewhere in the script,

include('config.php');

This means that the file "config.php" likely has all the configuration stuff in it, so you might find where the constant is set there.

If neither are present, you can **try** adding this to the very top of the script, anywhere within a PHP delimiter:

define('FROM', '[e-mail]');

Within the script, that would/should look like

<?php
define('FROM', '[e-mail]');

// OTHER PHP CODE HERE
?>

So all together, combining the constant and the code, what it should output is

From: [e-mail]\r\n
Reply-to: [e-mail]\r\n

[anon123]

I'm trying different things but it's not fixing it.

Here is the code your talking about from within formmail.php:

// To change the address the e-mail comes from use define('FROM', 'Example Name <[e-mail]>');
define('FROM', null);

I changed the "null" part to 'email' and it didn't fix it.

There is also this line:

// $recipient_array format is $recipient_array = array('sometext'=>'[e-mail]','asdf'=>'[e-mail]');
$recipient_array = array();

I changed the [e-mail] part to 'email' and that didn't do it either.

There is no config script, it's all in the formmail.php code, so I know it's probably a simple line I've got to edit, but just not sure what, lol.

[rocknbil]

There's no way that **shouldn't** work, but there is a small error there (I think.) :-) Did you quote it like the example shows? It really should be

define('FROM', '"Example Name" <[e-mail]>');

Note the double quotes surrounding the name. If that doesn't work try

define('FROM', '[e-mail]');

[anon123]

I give up on this script. There's many other free formmail php scripts out there, though. I'll just try and find one that works like this.

Thanks very much for all your help though rocknbil, I really do appreciate it. :)

Cheers.