php mail() multiple recipients

[PartisanEntity]

Hello all,

I am having issues trying to write a simple newsletter script, this is what I have so far:

<?php
//get the variables
$subject = $_POST['nform_newsltitle'];
$message = $_POST['nform_newsltext'];
$recipients = $_POST['nform_newslrecipients'];
$email = "[e-mail]";

//if ALL and SPECIFIC users have been selected, go back to the form with an error
if ($recipients[0] == "ALL" && strlen($recipients[1]) > 1) {

$link = 'Location: index.php?page=writenewsletter&newsl_error=1&newstitle='.$title.'&newsltext='.$text;
header($link);

} else {

//include our db data to make the connection
include ('db.php');

if ($recipients[0] == "ALL") {

$content1 = mysql_query("SELECT email FROM users WHERE newsletter = 1");

while($row = mysql_fetch_array($content1))
{
$to = $row['email'].',';
echo $to;
}

} else {

}

mail($to,$subject,$message,"From: ".$email.""); //a very simple send
?>

But it's only sending one email and ignoring the other recipients.

Any experienced users know what I am doing wrong?

Thank you!

[dreamcatcher]

You are overwriting the variable with each loop, so it will only be populated with the last address. Try:

$addresses = array();
while($row = mysql_fetch_array($content1))
{
addresses[] = $row['email'];
}

and then:

if (!empty($addresses)) {
mail(implode(',',$addresses),$subject,$message,"From: ".$email."");
}

dc

[Psychopsia]

Or add a dot in this line, just before =, as:

$to .= $row['email'].',';

[PartisanEntity]

Thanks guys.

I like the concatenation idea, so I went ahead with that.

Working.

[dreamcatcher]

On some servers the extra , would trigger an e-mail to nobody, so you might want to strip that.

dc

[Psychopsia]

The case dreamcatcher mentions, can be avoided by:

$to = '';
while($row = mysql_fetch_array($content1))
{
$to .= (($to != '') ? ', ' : '') . $row['email'];
echo $to;
}

[PartisanEntity]

actually i used rtrim($to, ",") to get rid of the last ','

[Psychopsia]

Also as my previous post, you should add:

$to = '';

To initialize $to before "while(" to avoid notice error if error_reporting is configured on server.