Forum Moderators: coopster
Here is my code.
<?php
//Registration form
function register_form(){
$date = date('D, M, Y');
echo "<form action='?act=register' method='post'>"
."Username: <input type='text' name='username' size='30'><br>"
."Password: <input type='password' name='password' size='30'><br>"
."Confirm your password: <input type='password' name='password_conf' size='30'><br>"
."Email: <input type='text' name='email' size='30'><br>"
."<input type='hidden' name='date' value='$date'>"
."<input type='submit' value='Register'>"
."</form>";
}
function register() {
$connect = mysql_connect(localhost, Securitized, securitized);
if (!$connect)
{
die(mysql_error());
}
$select_db = mysql_select_db(securitzed, $connect);
if (!$select_db) {
die(mysql_error());
}
//Collecting info
$username = $_POST['username'];
$password = $_POST['password'];
$pass_conf = $_POST['password_conf'];
$email = $_POST['email'];
$date = $_POST['date'];
//Here we will check do we have all inputs filled
if(empty('".$_REQUEST['username']."')){
die("Please enter your username!<br>");
}
if(empty('".$_REQUEST['password']."')){
die("Please enter your password!<br>");
}
if(empty('".$_REQUEST['password_conf']."')){
die("Please confirm your password!<br>");
}
if(empty('".$_REQUEST['email']."')){
die("Please enter your email!");
}
//Let's check if this username is already in use
$user_check = mysql_query("SELECT username FROM members WHERE username = '".$_REQUEST['username']."'");
$do_user_check = mysql_num_rows($user_check);
//Now if email is already in use
$email_check = mysql_query("SELECT email FROM members WHERE email= '".REQUEST['email']."'");
$do_email_check = mysql_num_rows($email_check);
//Now display errors
if($do_user_check > 0){
die("Username is already in use!<br>");
}
if($do_email_check > 0){
die("Email is already in use!");
}
//Now let's check does passwords match
if('".$_REQUEST['password']."'!= '".$_REQUEST['password_conf']."'){
die("Passwords don't match!");
}
//If everything is okay let's register this user
$insert = mysql_query("INSERT INTO members (username, password, email)
VALUES ('".$_REQUEST['username']."', '".$_REQUEST['password']."', '".$_REQUEST['email']."')");
if(!$insert){
die("There's little problem: ".mysql_error());
}
echo '".$_REQUEST['username']."'", you are now registered. Thank you!<br><a href=?
act=login>Login</a> ¦ <a href=index.php>Index</a>";
}
switch($act){
default;
register_form();
break;
case "register";
register();
break;
}
?>
[edited by: Garath531 at 6:50 pm (utc) on Mar. 9, 2007]
if (isset($_POST['register'])) {
function register() {
$connect = mysql_connect(localhost, Securitized, securitized);
if (!$connect)
{
die(mysql_error());
}
$select_db = mysql_select_db(securitzed, $connect);
if (!$select_db) {
die(mysql_error());
}
//Collecting info
$username = $_POST['username'];
$password = $_POST['password'];
$pass_conf = $_POST['password_conf'];
$email = $_POST['email'];
$date = $_POST['date'];
//Here we will check do we have all inputs filled
if(empty('".$_REQUEST['username']."')){
die("Please enter your username!<br>");
}
if(empty('".$_REQUEST['password']."')){
die("Please enter your password!<br>");
}
if(empty('".$_REQUEST['password_conf']."')){
die("Please confirm your password!<br>");
}
if(empty('".$_REQUEST['email']."')){
die("Please enter your email!");
}
//Let's check if this username is already in use
$user_check = mysql_query("SELECT username FROM members WHERE username = '".$_REQUEST
['username']."'");
$do_user_check = mysql_num_rows($user_check);
//Now if email is already in use
$email_check = mysql_query("SELECT email FROM members WHERE email= '".REQUEST['email']."'");
$do_email_check = mysql_num_rows($email_check);
//Now display errors
if($do_user_check > 0){
die("Username is already in use!<br>");
}
if($do_email_check > 0){
die("Email is already in use!");
}
//Now let's check does passwords match
if('".$_REQUEST['password']."'!= '".$_REQUEST['password_conf']."'){
die("Passwords don't match!");
}
//If everything is okay let's register this user
$insert = mysql_query("INSERT INTO members (username, password, email)
VALUES ('".$_REQUEST['username']."', '".$_REQUEST['password']."', '".$_REQUEST['email']."')");
if(!$insert){
die("There's little problem: ".mysql_error());
}
echo '".$_REQUEST['username']."'", you are now registered. Thank you!<br><a href=?
act=login>Login</a> ¦ <a href=index.php>Index</a>";
}
switch($act){
default;
register_form();
break;
case "register";
register();
break;
} }
else {
register_form()
}
Have you tried it? ;)
<?php
//Registration form
function register_form(){
$date = date('D, M, Y');
echo "<form action='register.php' method='post'>"
."Username: <input type='text' name='username' size='30'><br>"
."Password: <input type='password' name='password' size='30'><br>"
."Confirm your password: <input type='password' name='password_conf' size='30'><br>"
."Email: <input type='text' name='email' size='30'><br>"
."<input type='hidden' name='date' value='$date'>"
."<input type='submit' value='Register' name='register'>"
."</form>";
}
function register() {
$connect = mysql_connect("localhost", "demonchat_garat", "rolyat");
if (!$connect)
{
die(mysql_error());
}
$select_db = mysql_select_db("demonchat_chat", $connect);
if (!$select_db) {
die(mysql_error());
}
//Collecting info
$username = $_POST['username'];
$password = $_POST['password'];
$pass_conf = $_POST['password_conf'];
$email = $_POST['email'];
$date = $_POST['date'];
//Here we will check do we have all inputs filled
if(empty($_REQUEST['username'])){
die("Please enter your username!<br>");
}
if(empty($_REQUEST['password'])){
die("Please enter your password!<br>");
}
if(empty($_REQUEST['password_conf'])){
die("Please confirm your password!<br>");
}
if(empty($_REQUEST['email'])){
die("Please enter your email!");
}
//Let's check if this username is already in use
$user_check = mysql_query("SELECT username FROM members WHERE username = '".$_REQUEST['username']."'");
$do_user_check = mysql_num_rows($user_check);
//Now if email is already in use
$email_check = mysql_query("SELECT email FROM members WHERE email= '".$_REQUEST['email']."'");
$do_email_check = mysql_num_rows($email_check);
//Now display errors
if($do_user_check > 0){
die("Username is already in use!<br>");
}
if($do_email_check > 0){
die("Email is already in use!");
}
//Now let's check does passwords match
if($_REQUEST['password']!= $_REQUEST['password_conf']){
die("Passwords don't match!");
}
//If everything is okay let's register this user
$insert = mysql_query("INSERT INTO members (username, password, email)
VALUES ('".$_REQUEST['username']."', '".$_REQUEST['password']."', '".$_REQUEST['email']."')");
if(!$insert){
die("There's little problem: ".mysql_error());
}
echo $_REQUEST['username']; ", you are now registered. Thank you!<br>";
echo "<a href=act=login>Login</a> ¦ <a href=index.php>Index</a>";
}
switch($act){
default;
register_form();
break;
case "register";
register();
break;
}
if (isset($_POST['register'])){
register()
}
else {
register_form()
}
?>
I did notice that you are missing semi colons here
if (isset($_POST['register'])){
register()
}
else {
register_form()
}
both those function calls should end in a semi colon like so
if (isset($_POST['register'])){
register();
}
else {
register_form();
}