Canonical for HTTPS site pointing toward HTTP

Is this a problem?

[TomSnow]

Should I change the canonical to the HTTPS version of my HTTPS site?

All HTTPS pages currently point toward the HTTP version of themselves

[Selen]

Definitely yes.

[TomSnow]

Thanks, Selen.

[TomSnow]

@Selen and anyone else.

I noticed that some of my http pages are still ranking for queries. Is this bad, even though they redirect to the https version?

[phranque]

welcome to WebmasterWorld [webmasterworld.com], TomSnow!

Should I change the canonical to the HTTPS version of my HTTPS site?

yes!

All HTTPS pages currently point toward the HTTP version of themselves

I noticed that some of my http pages are still ranking for queries.

you are providing mixed signals and google is doing the best it can given the signals provided.

are you linking internally to the http: version?
do you have inbound links to the http: version?
does your sitemap (if any) refer to the http: version?
these signals may be overriding the fact that you are redirecting to the https: version.

even though they redirect to the https version?

are you using a 301 status code for these redirects?

you should created web properties for each of the following in google search console:
https://www.example.com
http://www.example.com
https://example.com
http://example.com

observing the provided information should help you figure out what's happening.