Forum Moderators: martinibuster

Message Too Old, No Replies

Is a png fix allowed by Google?

pngfix.js modification Google Code

         

tribal

1:22 pm on Apr 13, 2007 (gmt 0)

10+ Year Member



Hi,

I have a script to fix the transparency problem with png images in older browsers, but I'm wondering if this is allowed when I have Google AdSense on my page.

What the fix does is scan the page and place a filter around png images.

Is this allowed by Google since it is not allowed to alter the AdSense code?

And does the same thing count for e.g. a flash fix (where you don't have to click first to activate a flash movie)

Thanks for your opinion.
With kind regards,
Erik

fischermx

3:54 pm on Apr 13, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



How does that fix work?

marcel

5:52 pm on Apr 13, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



I've been running the PNG transparency Script for over two years on an AdSense website without any problems.

What makes you think using the script is altering the adsense code?

incrediBILL

6:03 pm on Apr 13, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member Top Contributors Of The Month



The script probably isn't a problem, but how old are the browsers you're trying to patch with this?

I stopped worrying about legacy browsers ages ago because:

a) XP/Win2K upgrade MSIE automatically
b) FireFox upgrades automatically
c) Anything that shows less than 1% in my stats isn't worth my time

It's not worth the bloat in a page to deal with people clinging to dinosaurs.

Powdork

3:30 am on Apr 14, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



And does the same thing count for e.g. a flash fix (where you don't have to click first to activate a flash movie)

I just add the parameter allowScriptAccess with the value sameDomain when calling the flash. It works with both the standard embed and with swfObject methods for calling the flash and i've used it on pages with adsense.
Like the png fix, this doesn't alter the adsense code.

marcel

6:38 pm on Apr 14, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



a) XP/Win2K upgrade MSIE automatically

Unfortunately, Win2k only supports IE6. And IE 6 does not support PNG transparency.

But, I agree, move with the times or be left behind...

HowYesNo

7:28 pm on Apr 14, 2007 (gmt 0)

10+ Year Member



don't get ban for doing this ;)
better put firefox ref button and tell people if you wanna see this ads without limitation download firefox hehehe :p

tribal

6:48 am on Apr 16, 2007 (gmt 0)

10+ Year Member



Thanks for the answers.

The fix script finds all images in the page and places a filter around any .png file it finds (filter:progid:DXImageTransform.Microsoft.AlphaImageLoader).

This fixed is used for IE6. We want our site to look great in IE7 and FireFox and it must look good in IE6.

inactivist

5:55 am on Apr 23, 2007 (gmt 0)

10+ Year Member



My understanding is that the png fixer script cannot access the iframe containing the adsense code (barring browser bugs - this is a browser XSS security issue, so the script can see all the stuff in the current page, but not in the adsense iframe.) Please correct me if I'm wrong...