Welcome to WebmasterWorld Guest from 107.22.87.205

Forum Moderators: open

Message Too Old, No Replies

Altering Banner Rotation

Altering Banner Rotation

     
3:44 pm on Jul 23, 2003 (gmt 0)

10+ Year Member



Hello, how to alter the code below of banner rotation to open in new window? Meanwhile,how to make it in .js? Because it's too long to put in the index page. I've try before and put the code <script language="JavaScript" type="text/JavaScript" src="banner.js"></SCRIPT>, but it doesn't work well and error.

Any help would be appreciated!

<SCRIPT language="JavaScript">
<!--

pic_width=468; /*change to match the height of all your images */
pic_height=60; /* change to match the width of all your images */
border_size=0; /* change to the border size you want on the images */
alignment=1; /* 0=left,1=center */

/* define image urls */

if (document.images)
{
pic1= new Image(pic_width,pic_height);
pic1.src="http://www.yoursite.com/1.jpg";
pic2= new Image(pic_width,pic_height);
pic2.src="http://http://www.yoursite.com/2.jpg";
pic3= new Image(pic_width,pic_height);
pic3.src="http://http://www.yoursite.com/3.jpg";
pic4= new Image(pic_width,pic_height);
pic4.src="http://www.http://www.yoursite.com/4.jpg";
pic5= new Image(pic_width,pic_height);
pic5.src="http://http://www.yoursite.com/5.jpg";
pic6= new Image(pic_width,pic_height);
pic6.src="http://http://www.yoursite.com/6.jpg";
pic7= new Image(pic_width,pic_height);
pic7.src="http://http://www.yoursite.com/7.jpg";

}

/* define banner urls */

urlad1="http://http://www.yoursite.com/1.html";
urlad2="http://http://www.yoursite.com/2.html";
urlad3="http://http://www.yoursite.com/3.html";
urlad4="http://http://www.yoursite.com/4.html";
urlad5="http://http://www.yoursite.com/5.html";
urlad6="http://http://www.yoursite.com/6.html";
urlad7="http://http://www.yoursite.com/7.html";

/* no need to edit past this point (unless you want to add more image and url slots) */

if (alignment==1)
{
cent_it="<CENTER>";
cent_it2="<\/CENTER>";
}
else
{
cent_it="";
cent_it2="";
}

function get_random(maxNum)
{
if (Math.random && Math.round)
{
var ranNum= Math.round(Math.random()*(maxNum-1));
ranNum+=1;
return ranNum;
}
else
{
today= new Date();
hours= today.getHours();
mins= today.getMinutes();
secn= today.getSeconds();
if (hours==19)
hours=18;
var ranNum= (((hours+1)*(mins+1)*secn)%maxNum)+1;
return ranNum;
}
}

function get_Image()
{
if (document.images)
{
var choose_one= get_random(7);
choose_one--;

var pics= new Array(7)
pics[0]=pic1.src;
pics[1]=pic2.src;
pics[2]=pic3.src;
pics[3]=pic4.src;
pics[4]=pic5.src;
pics[5]=pic6.src;
pics[6]=pic7.src;

var aurl= new Array(7)
aurl[0]=urlad1;
aurl[1]=urlad2;
aurl[2]=urlad3;
aurl[3]=urlad4;
aurl[4]=urlad5;
aurl[5]=urlad6;
aurl[6]=urlad7;

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"' height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);
}
}
//-->
</SCRIPT>

<SCRIPT language="JavaScript">
<!--
get_Image()
//-->
</SCRIPT>

6:36 pm on Jul 23, 2003 (gmt 0)

10+ Year Member



Welcome to WebmasterWorld!

My best guess is, near the bottom where it says:
border='"+border_size+"'>

change that to:
border='"+border_size+"' target='"_blank"'>

That might need a little tweaking, but that is basically what you need. That should do it for all banners. If you want to do it for individual banners that is a little more complicated. Then you would need to setup another variable for target.

As far as the external js file goes, make sure you are not including the opening and closing script tags in the js file.

10:36 am on Jul 24, 2003 (gmt 0)

10+ Year Member



I have altering to
border='"+border_size+"' target='"_blank"'>

But it didn't work :(

Please help!

10:48 am on Jul 24, 2003 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



change:

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"' height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

to:

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"' TARGET='_BLANK'><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"' height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

You were almost there - you'd put target='_blank' in the image tag, not the anchor tag...

11:21 am on Jul 24, 2003 (gmt 0)

10+ Year Member



Thanks alot! It works properly.

Now, about the js, I have try to remove the open and close tag, but still not work. Is ithis code properly for js?

pic_width=468; /*change to match the height of all your images */
pic_height=60; /* change to match the width of all your images */
border_size=0; /* change to the border size you want on the images */
alignment=1; /* 0=left,1=center */

/* define image urls */

if (document.images)
{
pic1= new Image(pic_width,pic_height);
pic1.src="http://www.yoursite.com/1.jpg";
pic2= new Image(pic_width,pic_height);
pic2.src="http://http://www.yoursite.com/2.jpg";
pic3= new Image(pic_width,pic_height);
pic3.src="http://http://www.yoursite.com/3.jpg";
pic4= new Image(pic_width,pic_height);
pic4.src="http://www.http://www.yoursite.com/4.jpg";
pic5= new Image(pic_width,pic_height);
pic5.src="http://http://www.yoursite.com/5.jpg";
pic6= new Image(pic_width,pic_height);
pic6.src="http://http://www.yoursite.com/6.jpg";
pic7= new Image(pic_width,pic_height);
pic7.src="http://http://www.yoursite.com/7.jpg";

}

/* define banner urls */

urlad1="http://http://www.yoursite.com/1.html";
urlad2="http://http://www.yoursite.com/2.html";
urlad3="http://http://www.yoursite.com/3.html";
urlad4="http://http://www.yoursite.com/4.html";
urlad5="http://http://www.yoursite.com/5.html";
urlad6="http://http://www.yoursite.com/6.html";
urlad7="http://http://www.yoursite.com/7.html";

/* no need to edit past this point (unless you want to add more image and url slots) */

if (alignment==1)
{
cent_it="<CENTER>";
cent_it2="<\/CENTER>";
}
else
{
cent_it="";
cent_it2="";
}

function get_random(maxNum)
{
if (Math.random && Math.round)
{
var ranNum= Math.round(Math.random()*(maxNum-1));
ranNum+=1;
return ranNum;
}
else
{
today= new Date();
hours= today.getHours();
mins= today.getMinutes();
secn= today.getSeconds();
if (hours==19)
hours=18;
var ranNum= (((hours+1)*(mins+1)*secn)%maxNum)+1;
return ranNum;
}
}

function get_Image()
{
if (document.images)
{
var choose_one= get_random(7);
choose_one--;

var pics= new Array(7)
pics[0]=pic1.src;
pics[1]=pic2.src;
pics[2]=pic3.src;
pics[3]=pic4.src;
pics[4]=pic5.src;
pics[5]=pic6.src;
pics[6]=pic7.src;

var aurl= new Array(7)
aurl[0]=urlad1;
aurl[1]=urlad2;
aurl[2]=urlad3;
aurl[3]=urlad4;
aurl[4]=urlad5;
aurl[5]=urlad6;
aurl[6]=urlad7;

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"' height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);
}
}
//-->
</SCRIPT>

<SCRIPT language="JavaScript">
<!--
get_Image()

4:09 pm on Jul 24, 2003 (gmt 0)

10+ Year Member



oops sorry for dropping that line in the wrong tag. :)

On the js code you missed removing this:
</SCRIPT>

<SCRIPT language="JavaScript">

from the bottom. :)

 

Featured Threads

Hot Threads This Week

Hot Threads This Month