Update a record

is my code right?

[Blelisa]

Hi I am trying to code an update, was wondering if my code is right? Thanks!
<%
Dim ID
ID=Request.QueryString("ID")

set connection=Server.CreateObject("ADODB.Connection")
connection.ConnectionString="Provider=Microsoft.Jet.OLEDB.4.0;Data Source=" &_
server.MapPath("/templates/test/developers.mdb")
connection.Open

sql="UPDATE [Bug] SET ([Tnum], [DateEntered], [BugDescription], [SimulatorsAffected], [SimulatorVersion], [Project], [EnteredBy], [FoundandReportedBy], [Priority], [Stat], [CorrectedDate], [CorrectedNotes])WHERE Tnum=" & ID & "" "
sql=sql & "VALUES"
sql=sql & "('" & Request.Form("number") & "',"
sql=sql & "'" & Request.Form("date") & "',"
sql=sql & "'" & Request.Form("desc") & "',"
sql=sql & "'" & Request.Form("simaff") & "',"
sql=sql & "'" & Request.Form("simver") & "',"
sql=sql & "'" & Request.Form("project") & "',"
sql=sql & "'" & Request.Form("entered") & "',"
sql=sql & "'" & Request.Form("found") & "',"
sql=sql & "'" & Request.Form("priority") & "',"
sql=sql & "'" & Request.Form("status") & "',"
sql=sql & "'" & Request.Form("datecorr") & "',"
sql=sql & "'" & Request.Form("corrected") & "')"

connection.Execute(sql)

if err<>0 then
Response.Write(Err.Description)
else
response.redirect("bugentered.htm")
end if
connection.close
%>

[Easy_Coder]

an update is more like...

update widgetTable
set fieldA = 'x',
fieldB = 'y',
fieldC = 'z'
where widgetid = 10

[Blelisa]

I am now getting syntax error in my update:
I am getting an syntax error in my update code
Can anyone help me understand what I am doing wrong?

Code:
<%
Dim ID
ID=Request.QueryString("ID")

set connection=Server.CreateObject("ADODB.Connection")
connection.ConnectionString="Provider=Microsoft.Jet.OLEDB.4.0;Data Source=" &_
server.MapPath("/templates/test/developers.mdb")
connection.Open

sql="UPDATE [Bug] SET ([Tnum], [DateEntered], [BugDescription], [SimulatorsAffected], [SimulatorVersion], [Project], [EnteredBy], [FoundandReportedBy], [Priority], [Stat], [CorrectedDate], [CorrectedNotes])WHERE Tnum=" & ID & ""
sql=sql & "VALUES"
sql=sql & "('" & Request.Form("date") & "',"
sql=sql & "'" & Request.Form("desc") & "',"
sql=sql & "'" & Request.Form("simaff") & "',"
sql=sql & "'" & Request.Form("simver") & "',"
sql=sql & "'" & Request.Form("project") & "',"
sql=sql & "'" & Request.Form("entered") & "',"
sql=sql & "'" & Request.Form("found") & "',"
sql=sql & "'" & Request.Form("priority") & "',"
sql=sql & "'" & Request.Form("status") & "',"
sql=sql & "'" & Request.Form("datecorr") & "',"
sql=sql & "'" & Request.Form("corrected") & "')"

connection.Execute(sql)

if err<>0 then
Response.Write(Err.Description)
else
response.redirect("bugentered.htm")
end if
connection.close

%>

[Easy_Coder]

Blelisa, look at the code I posted. That's how you write an update. Your code looks like it was taken from an Insert Statement....

To get you started

update Bug
set DateEntered = Request.Form("date"),
BugDescription = Request.Form("desc")
where Tnum=" & ID

I don't recommend passing unchecked values into the database though it's a terrible practice. This is just to give you an idea of what road you need to go down with your update statement.

[Blelisa]

Now I get:
Microsoft VBScript compilation error '800a03ea'

Syntax error

/templates/updating.asp, line 11

set "[DateEntered] = '" = Request.Form("date")& "', "

Code Is:
<%
Dim ID
ID=Request.QueryString("ID")

set connection=Server.CreateObject("ADODB.Connection")
connection.ConnectionString="Provider=Microsoft.Jet.OLEDB.4.0;Data Source=" &_
server.MapPath("/templates/test/developers.mdb")
connection.Open

sql="UPDATE [Bug] " &_
set "[DateEntered] = '" = Request.Form("date")& "', "
"[BugDescription] = '" & Request.Form("desc") & "', "
"[SimulatorsAffected] = '" & Request.Form("simaff") & "', "
"[SimulatorVersion] = '" & Request.Form("simver") & "', "
"[Project] = '" & Request.Form("project") & "', "
"[EnteredBy] = '" & Request.Form("entered") & "', "
"[FoundandReportedBy] = '" & Request.Form("found") & "', "
"[Priority] = '" & Request.Form("priority") & "', "
"[Stat] = '" & Request.Form("status") & "', "
"[Priority] = '" & Request.Form("priority") & "', "
"[status] = '" & Request.Form("status") & "', "
"[CorrectedDate] = '" & Request.Form("datecorr") & "', "
"[CorrectedNotes] = '" & Request.Form("corrected") & "', "

"WHERE Tnum=" & ID & ""

connection.Execute(sql)

if err<>0 then
Response.Write(Err.Description)
else
response.redirect("bugentered.htm")
end if
connection.close

%>

[mattglet]

sql="UPDATE [Bug] " & _
"set [DateEntered] = '" = Request.Form("date")& "', " & _
"[BugDescription] = '" & Request.Form("desc") & "', " & _
"[SimulatorsAffected] = '" & Request.Form("simaff") & "', " & _
"[SimulatorVersion] = '" & Request.Form("simver") & "', " & _
"[Project] = '" & Request.Form("project") & "', " & _
"[EnteredBy] = '" & Request.Form("entered") & "', " & _
"[FoundandReportedBy] = '" & Request.Form("found") & "', " & _
"[Priority] = '" & Request.Form("priority") & "', " & _
"[Stat] = '" & Request.Form("status") & "', " & _
"[Priority] = '" & Request.Form("priority") & "', " & _
"[status] = '" & Request.Form("status") & "', " & _
"[CorrectedDate] = '" & Request.Form("datecorr") & "', " & _
"[CorrectedNotes] = '" & Request.Form("corrected") & "', " & _

"WHERE Tnum=" & ID & ""

connection.Execute(sql)

[Blelisa]

Still not working but I think I am close
Error:
Microsoft JET Database Engine error '80040e14'

Syntax error (missing operator) in query expression 'Tnum='.

/templates/updating.asp, line 26

Code:

sql="UPDATE [Bug] "
sql = sql & " set [DateEntered] = '" & Request.Form("date") & "', "
sql = sql & "[BugDescription] = '" & Request.Form("desc") & "', "
sql = sql & "[SimulatorsAffected] = '" & Request.Form("simaff") & "', "
sql = sql & "[SimulatorVersion] = '" & Request.Form("simver") & "', "
sql = sql & "[Project] = '" & Request.Form("project") & "', "
sql = sql & "[EnteredBy] = '" & Request.Form("entered") & "', "
sql = sql & "[FoundandReportedBy] = '" & Request.Form("found") & "', "
sql = sql & "[Priority] = '" & Request.Form("priority") & "', "
sql = sql & "[Stat] = '" & Request.Form("status") & "', "
sql = sql & "[Priority] = '" & Request.Form("priority") & "', "
sql = sql & "[status] = '" & Request.Form("status") & "', "
sql = sql & "[CorrectedDate] = '" & Request.Form("datecorr") & "', "
sql = sql & "[CorrectedNotes] = '" & Request.Form("corrected") & "'"
sql = sql & "WHERE Tnum=" & ID & ""

connection.Execute(sql)

[Easy_Coder]

sql="UPDATE [Bug] "
sql = sql & " set [DateEntered] = '" & Request.Form("date") & "', "
sql = sql & "[BugDescription] = '" & Request.Form("desc") & "', "
sql = sql & "[SimulatorsAffected] = '" & Request.Form("simaff") & "', "
sql = sql & "[SimulatorVersion] = '" & Request.Form("simver") & "', "
sql = sql & "[Project] = '" & Request.Form("project") & "', "
sql = sql & "[EnteredBy] = '" & Request.Form("entered") & "', "
sql = sql & "[FoundandReportedBy] = '" & Request.Form("found") & "', "
sql = sql & "[Priority] = '" & Request.Form("priority") & "', "
sql = sql & "[Stat] = '" & Request.Form("status") & "', "
sql = sql & "[Priority] = '" & Request.Form("priority") & "', "
sql = sql & "[status] = '" & Request.Form("status") & "', "
sql = sql & "[CorrectedDate] = '" & Request.Form("datecorr") & "', "
sql = sql & "[CorrectedNotes] = '" & Request.Form("corrected") & "'"
sql = sql & "WHERE Tnum=" & ID

connection.Execute(sql)

[Blelisa]

Thank you all for your help! I figured it out and it is now operating correctly. I was not sending the tnum data correctly. Thanks Again!

[mrMister]

I notice you changed mattglett's code and ignored Easy_Coder's advice on unchecd values.

It seems you can take a horse to better code structure and security, but you can't make it drink!

[Blelisa]

Nope, not it at all.....will work on security next...wanted to figure out how to get it too do what I want first then will worry about security, this site is not going to be published up on the web for quite awhile yet, so I have some time to learn all this by trial and fire