Forum Moderators: open

Message Too Old, No Replies

Broken pipes

Why converted?

         

adni18

11:55 pm on Sep 29, 2004 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



Why are all non-broken pipelines converted into broken pipelines (¦) here?

DrDoc

6:21 pm on Oct 4, 2004 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



That's the simple nature of the Perl script that processes the post. It is set to url-decode the posted data. Thus, %40 becomes @, etc.

Still, it shouldn't be too hard to convert the pipe separately before the rest.

mincklerstraat

8:17 pm on Nov 8, 2004 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



This would be a great advantage. I don't know how many times I've had something break, either on my side from copied code, or in code I wrote that was reported by someone as not working, and only a good deal later realized, 'it's them pipes'! (just had one again so I post this here - sorry if thread is too old)

bakedjake

10:45 pm on Nov 8, 2004 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



Security. You don't want unbroken pipes going through the system.

Brett_Tabke

11:51 am on Nov 9, 2004 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



Jakes got it - that is the reason - a pipe character will never be stored in the db here. That alone eliminates tens of thousands of potential hacks that hit other bbs systems.

ddent

1:57 am on Nov 10, 2004 (gmt 0)

10+ Year Member



As I'm sure Brett can attest to, consider that writing something to parse input from untrusted users and remove any nasties while still allowing markup is extremely challenging; it is very easy to make a mistake.

Brett_Tabke

8:29 pm on Nov 10, 2004 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



just fyi: the pipe character is an extremely powerful command line operator under Unix. It is one of the top all time ways to hack web based Unix apps.

shri

1:17 am on Nov 11, 2004 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



>> It is one of the top all time ways to hack web based Unix apps.

Brett, your code is showing its age. Please don't tell me your search is widget_web_app ¦ grep $query ¦ reformat_web_app (err .. u know what I mean... )

mincklerstraat

1:21 pm on Nov 11, 2004 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member



Thanks for the info guys. Yes, indeed, sanitizing user input can be hell, if you have to make special allowances for certain things but also need to stymie hack attacks.

Just a thought, but maybe in a future edition of the WebmasterWorld bbcode, you could have [pipe], and convert all pipes to [pipe], and output [pipe] with

|
? Or maybe convert something like þ to this?