Welcome to WebmasterWorld Guest from 188.8.131.52
Talk to your friend. Tell him you looked over the code. Ask why he prefers this method over that method. Don't come off as judgmental but instead as interested in the approach to the solution.
another developer here at work...
... leave it pinned up on our manager's office door?
I think it could have been done better.
Things like using interfaces
this is where you learn that your my coworker, not my boss
pinned up on our manager's office doorwas that supposed to be a joke?
It is almost universally true in programming that those who can't, manage those who can
Ask yourself, does this thought come from your ego or solid facts that you can document and reference?
Politely asking why it's been written the way it has
Now I've had time to think about it, I have to admit it's a bit of both. If I'm honest, I think I'm just a bit jealous - I would have loved to work on a project like that. Even though there are some solid facts I could point out as 'not ideal', I think the reason for pointing them out in the first place was most likely due to that jealously, and maybe, subconsciously, I'm secretly hoping that management will turn around and say 'Yes, you're right. This whole thing won't work. Let's scrap it, and we'll give it to you to do properly. Now, go forth, and make us proud. And have a raise while you're at it. And your own office. And a title.' Hmm...maybe not!
Things like using interfaces, and abstraction into methods. To me, they are obvious things to have done, but in this case, they've not been done.Ok, sounds like you're talking about object-orientation and Windows in particular. If I'm right, listen up...
you dont give your neighbours the benefit of your parenting advice every time you see their kids playing around, because its none of your business.