PHP Redirect script

[kellyman]

Hi Guys

Posted a while back in regard to a htaccess script for a new domain

want to kind of ask the same question but with PHP script

I have a site which is going to be directed in the coming weeks to a new site, the below code should solve the Canonical issues as well as any capitalized letters and the forward stroke at the end of URL's i can kind of get my head around this and all looks fine but below is the full code for doing this but i cannot help but think there is a duplication in there some where.

is it possible someone can have a look and let me know if this does all that it should as simply as possible as it looks to me theres 2 occasions where is asks for lower case

if ($requrl=="/" and substr($_SERVER["SERVER_NAME"],0,4)<>"www."){

$correcturl=strtolower($svr);
header("HTTP/1.1 301 Moved Permanently");
header("Location: $correcturl");
exit;

}else if (substr($_SERVER["SERVER_NAME"],0,4)<>"www." or ($requrl<>"/" and substr($requrl,-1)=="/") or $requrl<>strtolower($requrl)){

$correcturl=strtolower(rtrim("$svr$requrl","/"));
header("HTTP/1.1 301 Moved Permanently");
header("Location: $correcturl");
exit;
}

[eelixduppy]

You should try to avoid code duplication as much as possible. Here, the only thing changing is the value of

$correcturl

. Everything else should be consolidated:

$serverNamePrefix = substr($_SERVER['SERVER_NAME'], 0, 4); 
$correctUrl = ''; 

if($serverNamePrefix != 'www.' && $requrl == '/') { 
  $correctUrl = strtolower($svr); 
} else if($serverNamePrefix != 'www.' || ($requrl != '/' && substr($requrl, -1) == '/') || ($requrl != strtolower($requrl))) { 
  $correctUrl = strtolower(rtrim($svr.$requrl, '/')); 
} 

 header('HTTP/1.1 301 Moved Permanently'); 
 header('Location: ' . $correctUrl); 
 exit; 

something like that, perhaps.

[kellyman]

Thank you

although I don't know too much about code i could see duplication there so many thanks for clarifying for me

[matrix_jan]

Else ifs don't like to be consolidated :)

[g1smd]

You'll need to invoke the PHP script from a RewriteRule configured as an internal rewrite.

If you mistakenly redirect to the PHP script you will generate an unwanted multiple step rediction chain.


Make sure the target URL of the PHP-generated redirect includes the full protocol and domain as well as the path.

[kellyman]

Thats not the first time i read that, its kind of hard as i know that there is an error but not experienced to rectify what he has done, I can find example of individual codes such as site to site redirect and canonical , and then the trailing slash

however i cannot find the correct answer to all which is

canonical www. and non www.
remove trailing slash
redirect any upper case urls

as those above are being addresed now and i know when i move the site they will need to be actioned.

can you point me in an example of exactly what i need as i cannot afford to get this wrong and unfortunately I dont know enough

[g1smd]

preg_replace()

allows you to strip the slash.

strtolower()

will fix the casing.

The target URL specified in the PHP-generated redirect must include protocol and domain. This will take care of the non-www/www problem.

Thorough testing is important. I assume you do have a test sub-domain? Test in a sub-domain not in a folder.