Is it OK to have a return in a loop?

[csdude55]

Before I rely on this, I want to make sure there's not a logical error with it.

I'm currently doing something like:

$filter = 0;

@arr = {
 'one' => 1,
 'two' => 2,
 ...
 'ninety nine' => 99
};

foreach (keys @arr) {
 if (/foo/) { $filter = $arr{$_}; last; }
}

if (!$filter && $something_else eq 'bar') { $filter = 100; }

if ($filter) { return $filter; }

Is there any reason why I shouldn't do it like this and eliminate $filter entirely?

foreach (keys @arr) {
 if (/foo/) { return $arr{$_}; exit; }
}

if ($something_else eq 'bar') { return 100; }

[Brett_Tabke]

Nope, I do it a bunch of places here (even in the middle of the massive DecodePost routine (500 lines). Good info in this Perl Monks thread:


[perlmonks.org...]