---- Colleague's code. Am I allowed to pick holes in it?
kaled - 1:59 pm on Oct 6, 2010 (gmt 0)
Things like using interfaces, and abstraction into methods. To me, they are obvious things to have done, but in this case, they've not been done.
Ok, sounds like you're talking about object-orientation and Windows in particular. If I'm right, listen up...
Keep your nose out it - it's not your project. Such decisions may be due to programming style but they may also be down to practical problems that you are simply unaware of. If the code works properly and fulfils the role it was designed for, that's good enough. Moving certain code into objects can be done easily at a later date if necessary.
I'll give you an example - I implemented zip-file inflate a few years ago. I then decided it would be nice to re-do it with object orientation but as well as adding to code bloat it slowed the code down horribly so I ditched it.