---- Colleague's code. Am I allowed to pick holes in it?
bhonda - 9:18 am on Oct 6, 2010 (gmt 0)
pinned up on our manager's office door
was that supposed to be a joke?
Yes. Yes that was a joke. Sorry - I always forget tone never comes through in text!
I'm appreciating all the discussions on this.
It is almost universally true in programming that those who can't, manage those who can
I'm saddened to say that this is exactly the case here. I'm conscious of the fact that there is nobody else above me who would even consider looking at code in this way - I suppose it comes with working in such a small team (there are only 4 main developers here).
Ask yourself, does this thought come from your ego or solid facts that you can document and reference?
Now I've had time to think about it, I have to admit it's a bit of both. If I'm honest, I think I'm just a bit jealous - I would have loved to work on a project like that. Even though there are some solid facts I could point out as 'not ideal', I think the reason for pointing them out in the first place was most likely due to that jealously, and maybe, subconsciously, I'm secretly hoping that management will turn around and say 'Yes, you're right. This whole thing won't work. Let's scrap it, and we'll give it to you to do properly. Now, go forth, and make us proud. And have a raise while you're at it. And your own office. And a title.' Hmm...maybe not!
Seriously though, all emotions aside, I've got every confidence that this project will actually work, and the vast majority of it looks brilliant. There are a handful of little things that do throw up a little warning flag for me, but they are not life-or-death issues.
Politely asking why it's been written the way it has
I think that's it - I'm well aware that I don't know everything. I guess I just need to have a chat about it. It could be the case that my friend just didn't think about it when they were writing it. Or it could be the result of weeks of research and testing to make sure it was the best solution. I have no idea. It would be good to find out!