|Classic ASP - Lcase operation on array taking too long|
Classic ASP - Lcase operation on array taking too long
I'm working with a script designed to compare values returned from a form against values from a database dumped to an array, via GetRows.
Currently, the code uses an inner and outer loop to run this comparison, with a temporary variable being assigned the current col/row from the
aforementioned array. An lcase and trim operation are performed on the value to obtain the temporary variable.
This is causing a considerable performance drain, and I was wondering if the lcase/trim functionality could perhaps be performed during the creation
of that array, rather than in a looping situation?
Here's my code:
**note: this utilizes the FastString Class for concatenation, thus the "FastString" and ".Append"
dim iRowLoop, iColLoop, zRowLoop, strChange, tempDbValsCase
Set strChange = New FastString
for iRowLoop = 0 to ubound(arrDbVals, 2)
for zRowLoop = 0 to ubound(arrFormComplete)
'****below line is what is causing the bottleneck, according
'****to a timer test
tempDbValsCase = lcase(trim(arrDbVals(1, iRowLoop)))
if (mid(trim(arrFormComplete(zRowLoop)),1,8) = trim(arrDbVals(0, iRowLoop))) AND (mid(trim(arrFormComplete(zRowLoop)),9) <> tempDbValsCase)
strFormAllVals = arrFormComplete(zRowLoop)
strChange.Append strFormAllVals & ","
On the database side, the table from which the array is derived through GetRows contains the bit datatype column "Complete". The lcase and trim
operations are performed upon this column of the array. Does the bit datatype add any hidden characters in the output? Visually, I don't detect
any, but when I compare a value of "True" from the form input against a value from the array that looks like "True," it doesn't match, until I run
the lcase and trim on the "Complete" column.
Thanks for any help!
Kind Regards :)
Why not use a sql statement to do the entire search or reduce the amount of rows you have to search though the database and let the DB do the heavy lifting?
Would you be referring to using a Stored Procedure to do the comparisons?
Yes either a stored procedure or ADO command object using sql string with strongly typed parameters, to avoid injection attacks.
By having the Database do the comparison it should speed things up since it doesn't have to send as much data back and forth between the db and ASP.
Thanks for your response.
The data from the form that is compared against the database...would that data (cycled through an array) be input to SQL server as an array, somehow?
I am not sure why you are putting it into an array in the first place. But normally a sql server can not process an array being passed into it, its not impossible but not usually the best method for databases.
I am going to make an assumption that the database table you are comparing against has unique ID assigned to each row also called a primary key. And that you can use this to determine which rows in the db you need to update via your form.
The array is needed because the form posts many rows to the same table - the form has approx 300 rows, some of which change, and some that don't. Each of those goes into the array, which is then compared against the DB rows that already exist, to compare for changes.
When I am developing a site I normally try to avoid this situation altogether because of the bottle necks you are having.
If I was in this situation, I would end up coding the update stored procedure to work on a single row, and loop though updating row by row. In most databases the stored procedures are strongly typed. But it would only update the record if one of the fields was different then what was currently available.
The main point I am trying to make is I would push the checking of the data into the database level, and out of the Classic ASP code. This will avoid having to pull all that data back down again, then push the updates back.